From e825a51b30261b55c536af18fefde79dc6308377 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Karl-Einar=20Bergstr=C3=B8m?= <karl-einarb@outlook.com>
Date: Wed, 14 Oct 2026 21:23:06 +0200
Subject: [PATCH] fix: local builds are dev-<commit> again, not a Go
 pseudo-version (#68)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Go now stamps local builds with a module pseudo-version (v0.1.3-0.20261014174204-1c31a75d0507+dirty), so the version showed that instead of dev-<commit> as the docs say. The update check also took it for a pre-release of 0.1.3, a version that doesn't exist, rather than a development build. A pseudo-version is now dev-<its commit>, -dirty with uncommitted changes; real versions are unchanged.

Reviewed-on: https://git.kebcloud.no/keb/lazysecrets/pulls/68
Co-authored-by: Karl-Einar Bergstrøm <karl-einarb@outlook.com>
---
 cmd/lazysecrets/version.go      | 22 ++++++++++++++++++++--
 cmd/lazysecrets/version_test.go | 22 ++++++++++++++++++++++
 2 files changed, 42 insertions(+), 2 deletions(-)
 create mode 100644 cmd/lazysecrets/version_test.go

diff --git a/cmd/lazysecrets/version.go b/cmd/lazysecrets/version.go
index bd96948..19ebf32 100644
--- a/cmd/lazysecrets/version.go
+++ b/cmd/lazysecrets/version.go
@@ -1,6 +1,10 @@
 package main
 
-import "runtime/debug"
+import (
+	"regexp"
+	"runtime/debug"
+	"strings"
+)
 
 // version is set by release builds:
 //
@@ -8,7 +12,12 @@ import "runtime/debug"
 var version string
 
 // versionString is the release version, or for other builds what Go
-// recorded: the module version (go install …@v1.2.3), else the commit.
+// recorded: the module version (go install …@v1.2.3), else the commit
+// (dev-c1a4f90, -dirty with changes not committed).
+// pseudo matches a Go pseudo-version (v0.1.3-0.20261014174204-1c31a75d0507,
+// maybe +dirty): its commit.
+var pseudo = regexp.MustCompile(`[-.]\d{14}-([0-9a-f]{12})(\+.*)?$`)
+
 func versionString() string {
 	if version != "" {
 		return version
@@ -18,6 +27,15 @@ func versionString() string {
 		return "dev"
 	}
 	if v := bi.Main.Version; v != "" && v != "(devel)" {
+		// A commit, not a release: a local build (Go stamps those too) or
+		// go install …@<commit>.
+		if m := pseudo.FindStringSubmatch(v); m != nil {
+			dirty := ""
+			if strings.HasSuffix(v, "+dirty") {
+				dirty = "-dirty"
+			}
+			return "dev-" + m[1][:7] + dirty
+		}
 		return v
 	}
 	var rev, dirty string
diff --git a/cmd/lazysecrets/version_test.go b/cmd/lazysecrets/version_test.go
new file mode 100644
index 0000000..28730bf
--- /dev/null
+++ b/cmd/lazysecrets/version_test.go
@@ -0,0 +1,22 @@
+package main
+
+import "testing"
+
+func TestPseudoVersions(t *testing.T) {
+	for v, want := range map[string]string{
+		"v0.1.3-0.20261014174204-1c31a75d0507":       "1c31a75d0507",
+		"v0.1.3-0.20261014174204-1c31a75d0507+dirty": "1c31a75d0507",
+		"v0.0.0-20261014174204-1c31a75d0507":         "1c31a75d0507",
+		"v0.2.0-rc.1.0.20261014174204-1c31a75d0507":  "1c31a75d0507",
+		"v0.1.2":      "",
+		"v0.2.0-rc.1": "",
+	} {
+		got := ""
+		if m := pseudo.FindStringSubmatch(v); m != nil {
+			got = m[1]
+		}
+		if got != want {
+			t.Errorf("%s: %q, want %q", v, got, want)
+		}
+	}
+}