feat: show and hide in the help bar, the same width so it doesn't shift (#24)
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit was merged in pull request #24.
This commit is contained in:
1 parent
949d069806
commit
abb9c57630
3 files changed
+5
-4
No files matched your search
@@ -988,7 +988,7 @@ func TestRebindingShowsEverywhere(t *testing.T) {
|
|||||||
if !strings.Contains(scr, "z to reveal") || strings.Contains(scr, "space to reveal") {
|
if !strings.Contains(scr, "z to reveal") || strings.Contains(scr, "space to reveal") {
|
||||||
t.Errorf("detail hint doesn't follow the binding:\n%s", scr)
|
t.Errorf("detail hint doesn't follow the binding:\n%s", scr)
|
||||||
}
|
}
|
||||||
if !strings.Contains(lastLine(scr), "z reveal") || strings.Contains(lastLine(scr), "reveal/hide") {
|
if !strings.Contains(lastLine(scr), "z show") {
|
||||||
t.Errorf("help bar: %q", lastLine(scr))
|
t.Errorf("help bar: %q", lastLine(scr))
|
||||||
}
|
}
|
||||||
d.keys("z")
|
d.keys("z")
|
||||||
|
|||||||
@@ -39,7 +39,8 @@ type contextHelp struct {
|
|||||||
account bool // the fourth pane shows Fields (fields.go)
|
account bool // the fourth pane shows Fields (fields.go)
|
||||||
of pane // what the fourth pane describes
|
of pane // what the fourth pane describes
|
||||||
// revealed, when set, says whether the selected value is shown, so
|
// revealed, when set, says whether the selected value is shown, so
|
||||||
// the reveal key says just what it'll do: reveal or hide.
|
// the reveal key says just what it'll do: show or hide, the same
|
||||||
|
// width so the bar doesn't shift.
|
||||||
revealed *bool
|
revealed *bool
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -68,7 +69,7 @@ func (c contextHelp) ShortHelp() []key.Binding {
|
|||||||
default:
|
default:
|
||||||
reveal := k.Reveal
|
reveal := k.Reveal
|
||||||
if c.revealed != nil {
|
if c.revealed != nil {
|
||||||
reveal = key.NewBinding(key.WithKeys(k.Reveal.Keys()...), key.WithHelp(k.Reveal.Help().Key, map[bool]string{false: "reveal", true: "hide"}[*c.revealed]))
|
reveal = key.NewBinding(key.WithKeys(k.Reveal.Keys()...), key.WithHelp(k.Reveal.Help().Key, map[bool]string{false: "show", true: "hide"}[*c.revealed]))
|
||||||
}
|
}
|
||||||
b = append(b, reveal, k.Copy, k.Share, k.ShareMenu, k.Versions, k.Favourite, k.Filter)
|
b = append(b, reveal, k.Copy, k.Share, k.ShareMenu, k.Versions, k.Favourite, k.Filter)
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -136,7 +136,7 @@ func TestLayoutIsSaved(t *testing.T) {
|
|||||||
func TestContextHelpBar(t *testing.T) {
|
func TestContextHelpBar(t *testing.T) {
|
||||||
t.Parallel()
|
t.Parallel()
|
||||||
d := newDriver(t)
|
d := newDriver(t)
|
||||||
if bar := lastLine(d.screen()); !strings.Contains(bar, "S share") || !strings.HasSuffix(strings.TrimSpace(bar), "? help • q quit") || strings.Contains(bar, "space reveal") {
|
if bar := lastLine(d.screen()); !strings.Contains(bar, "S share") || !strings.HasSuffix(strings.TrimSpace(bar), "? help • q quit") || strings.Contains(bar, "space show") {
|
||||||
t.Errorf("Sources help bar: %q", bar)
|
t.Errorf("Sources help bar: %q", bar)
|
||||||
}
|
}
|
||||||
d.keys("3")
|
d.keys("3")
|
||||||
|
|||||||
Reference in new issue
Block a user