Merge branch 'main' into feat/status-pane

cliff.toml

@@ -24,7 +24,8 @@ Hello world 👋
 {% for group, commits in commits | group_by(attribute="group") %}
 ### {{ group | striptags | trim }}
 {% for commit in commits %}
-- {% if commit.breaking %}**Breaking:** {% endif %}{{ commit.message | split(pat="\n") | first | upper_first | trim }}\
+- {% if commit.breaking %}**Breaking:** {% endif %}{{ commit.message | split(pat="\n") | first | upper_first | trim }} \
+([{{ commit.id | truncate(length=7, end="") }}](https://git.kebcloud.no/keb/lazysecrets/commit/{{ commit.id }}))\
 {% endfor %}
 {% endfor %}\n
 """
@@ -33,6 +34,8 @@ trim = true
 # Runs on each part (header, every release) separately.
 postprocessors = [
   { pattern = "\n{3,}", replace = "\n\n" },
+  # Squash commits end in the PR's number: link it.
+  { pattern = "\\(#([0-9]+)\\)", replace = "([#${1}](https://git.kebcloud.no/keb/lazysecrets/pulls/${1}))" },
 ]
 
 [git]

internal/update/update.go

@@ -22,6 +22,7 @@ import (
 	"os/exec"
 	"path"
 	"path/filepath"
+	"regexp"
 	"runtime"
 	"strings"
 	"time"
@@ -49,9 +50,13 @@ type Release struct {
 // every release ends with.
 func (r Release) Notes() string {
 	notes, _, _ := strings.Cut(r.Body, "## Install")
-	return strings.TrimSpace(notes)
+	return mdLink.ReplaceAllString(strings.TrimSpace(notes), "$1")
 }
 
+// mdLink is a Markdown link, [text](url): the notes link PRs and commits,
+// and a terminal shows them as their text.
+var mdLink = regexp.MustCompile(`\[([^\]]+)\]\((https?://[^)\s]+)\)`)
+
 // Client talks to the release server.
 type Client struct {
 	API  string // the repository's API, DefaultAPI when empty

internal/update/update_test.go

@@ -123,3 +123,10 @@ func TestInstallRefusesATamperedArchive(t *testing.T) {
 		t.Error("replaced anyway")
 	}
 }
+
+func TestNotesShowLinksAsText(t *testing.T) {
+	r := Release{Body: "### Added\n\n- Search ([#11](https://git.example.com/pulls/11)) ([65dc2d7](https://git.example.com/commit/65dc2d7abc))\n\n## Install\n\ncurl …"}
+	if got, want := r.Notes(), "### Added\n\n- Search (#11) (65dc2d7)"; got != want {
+		t.Errorf("notes %q, want %q", got, want)
+	}
+}