feat: lazysecrets list shows unreadable lists as red ✗ lines, and filters by kind

internal/listing/listing_test.go

@@ -34,18 +34,23 @@ func (c *counting) Objects(ctx context.Context, ct provider.Container, t provide
 	return c.Provider.Objects(ctx, ct, t)
 }
 
-func run(t *testing.T, o Options) ([]Entry, cachefile.File, []error) {
+// run lists, returning the entries and, apart, the lists that failed.
+func run(t *testing.T, o Options) ([]Entry, cachefile.File, []Entry) {
 	t.Helper()
 	if o.Cache.Version == 0 {
 		o.Cache = cachefile.New()
 	}
 	o.Timeout = func(provider.Kind) time.Duration { return 5 * time.Second }
-	var got []Entry
-	f, errs := Run(context.Background(), o, func(e Entry) error {
-		got = append(got, e)
+	var got, failed []Entry
+	f := Run(context.Background(), o, func(e Entry) error {
+		if e.Error != "" {
+			failed = append(failed, e)
+		} else {
+			got = append(got, e)
+		}
 		return nil
 	})
-	return got, f, errs
+	return got, f, failed
 }
 
 func has(es []Entry, kind, path string) bool {
@@ -69,8 +74,8 @@ func TestListLoadsAndCaches(t *testing.T) {
 			t.Errorf("no %s %s", want[0], want[1])
 		}
 	}
-	if len(errs) != 1 || !strings.Contains(errs[0].Error(), "kv-restricted: 403") {
-		t.Errorf("errs = %v", errs)
+	if len(errs) != 1 || errs[0].Kind != "vault" || errs[0].Path[1] != "kv-restricted" || !strings.Contains(errs[0].Error, "403") || errs[0].Link == "" {
+		t.Errorf("failed = %+v", errs)
 	}
 	seen := map[string]bool{}
 	for _, e := range got {
@@ -160,10 +165,14 @@ func TestListStopsWhenTheReaderGoes(t *testing.T) {
 	t.Parallel()
 	gone := errors.New("broken pipe")
 	n := 0
-	_, errs := Run(context.Background(), Options{
+	var errs []Entry
+	Run(context.Background(), Options{
 		Providers: []provider.Provider{fake.Azure(0), fake.Repos()}, Cache: cachefile.New(), MaxAge: time.Minute,
 		Timeout: func(provider.Kind) time.Duration { return time.Second },
-	}, func(Entry) error {
+	}, func(e Entry) error {
+		if e.Error != "" {
+			errs = append(errs, e)
+		}
 		n++
 		if n == 2 {
 			return gone
@@ -174,3 +183,31 @@ func TestListStopsWhenTheReaderGoes(t *testing.T) {
 		t.Errorf("emitted %d after the reader went, errs %v", n, errs)
 	}
 }
+
+func TestListKinds(t *testing.T) {
+	t.Parallel()
+	// Sources only: nothing under them is asked for.
+	az := &counting{Provider: fake.Azure(0)}
+	got, _, _ := run(t, Options{Providers: []provider.Provider{az}, MaxAge: time.Minute, Kinds: []string{"source"}})
+	if len(got) == 0 || az.calls.Load() != 1 {
+		t.Errorf("%d sources, %d requests, want just the sources'", len(got), az.calls.Load())
+	}
+	for _, e := range got {
+		if e.Kind != "source" {
+			t.Errorf("listed a %s", e.Kind)
+		}
+	}
+	// Keys, asked for: loaded, though Go to wouldn't; no secrets.
+	got, _, failed := run(t, Options{Providers: []provider.Provider{fake.Azure(0)}, MaxAge: time.Minute, Kinds: []string{"key"}})
+	if !has(got, "key", "platform-prod/kv-app-prod/signing-key") {
+		t.Errorf("no keys: %+v", got)
+	}
+	for _, e := range got {
+		if e.Kind != "key" {
+			t.Errorf("listed a %s", e.Kind)
+		}
+	}
+	if len(failed) == 0 {
+		t.Error("a list that failed wasn't listed")
+	}
+}